abstractdog commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354559556
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##########
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"4", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"704", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"705", parameters.get("totalSize"));
Review Comment:
I just unresolved this conversation, it's time to finally address this whole
totalSize somehow
option 5) would be to create another ticket to remove that stuff, merge
ASAP, and then we can see how clear is this upgrade alone, because
masking/totalSize related changes won't bring the noise into this PR, so I
guess this is even better than 1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
