zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1354876487
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java:
##########
@@ -848,7 +848,7 @@ public void testCompactStatsGather() throws Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"1", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"4", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"704", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"705", parameters.get("totalSize"));
Review Comment:
Option 5 means we remove only the totalSize checks which are in this ticket
and not others, which would be a little bit weird, because it is hard to
address which to eliminate outside this ticket. How can be the other ticket
reviewed without this? So I would say create a ticket with clear description
which to delete: a) from Qtests, b) Qtest and unit tests. Or create 2 new
ticket, one for Qtests only, one for unit tests only. Since the build env is
really unstable I had to run many times this build to finally succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
