dengzhhu653 commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1627242981


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java:
##########
@@ -61,7 +62,7 @@ public void analyzeInternal(ASTNode root) throws 
SemanticException {
     boolean isDbLevelLock = true;
     if (cascade) {
       try {
-        List<Table> tables = db.getAllTableObjects(databaseName);
+        List<Table> tables = db.getAllTableObjects(databaseName, true);

Review Comment:
   There is a `hive.metastore.client.filter.enabled` to disable the client 
filter, we can use it instead of depend on a new method, e.g
   ```java
   try {
      HiveConf hiveConf = new HiveConf(conf);
      conf.set("hive.metastore.client.filter.enabled", "false");
      Hive db = Hive.get(hiveConf);
      ....
   } finally {
      // restore
      db = Hive.get(conf);
    }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to