saihemanth-cloudera commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1630453899
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java:
##########
@@ -61,7 +62,7 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
boolean isDbLevelLock = true;
if (cascade) {
try {
- List<Table> tables = db.getAllTableObjects(databaseName);
+ List<Table> tables = db.getAllTableObjects(databaseName, true);
Review Comment:
I'll implement this suggestion as setting config in session is not taken
into effect. we don't need a finally block since we are creating a new variable
'db' instead of overriding the already existing one. Also, the existing
variable 'db' is a final variable so we cannot override it.
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java:
##########
@@ -60,7 +62,13 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
// if cascade=true, then we need to authorize the drop table action as
well, and add the tables to the outputs
boolean isDbLevelLock = true;
if (cascade) {
+ SessionState sessionState = SessionState.get();
try {
+ HiveConf hiveConf = new HiveConf(conf);
+ hiveConf.set("hive.metastore.client.filter.enabled", "false");
+ if (sessionState != null) {
Review Comment:
Ack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
