saihemanth-cloudera commented on code in PR #5275: URL: https://github.com/apache/hive/pull/5275#discussion_r1630451680
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java: ########## @@ -73,6 +74,11 @@ public void analyzeInternal(ASTNode root) throws SemanticException { } outputs.add(new WriteEntity(table, lockType)); } + // fetch all the functions in the database + List<Function> functions = db.getFunctionsInDb(databaseName, ".*"); Review Comment: I still think this method would be useful if we decide to enforce client-side filtering on functions in the future. @nrg4878 -- Can you please share your suggestion here on whether to add a new API for fetching functions in a database or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org