dengzhhu653 commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1627250255
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java:
##########
@@ -73,6 +74,11 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
}
outputs.add(new WriteEntity(table, lockType));
}
+ // fetch all the functions in the database
+ List<Function> functions = db.getFunctionsInDb(databaseName, ".*");
Review Comment:
Given in reality, the number of permanent functions stored in remote db
should be smaller compared to the other meta, I think we can use
`db.getAllFunctions` then select the functions belonging to this database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
