dengzhhu653 commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1630530346


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseAnalyzer.java:
##########
@@ -61,7 +62,7 @@ public void analyzeInternal(ASTNode root) throws 
SemanticException {
     boolean isDbLevelLock = true;
     if (cascade) {
       try {
-        List<Table> tables = db.getAllTableObjects(databaseName);
+        List<Table> tables = db.getAllTableObjects(databaseName, true);

Review Comment:
   The new created `db` will overwrite the thread-local hive, and the 
underlying client disables the client filtering, if we use this client for 
other calls in the future, it may cause problems. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to