deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923756268
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:
##########
@@ -458,6 +460,18 @@ private void printSummary(boolean success, Map<String,
Progress> progressMap) {
}
}
+ public void endSummary() {
+ console.endSummary();
+ }
+
+ /**
+ * Collecting execution summary might be a bit expensive, only do it if
needed for query history.
+ */
+ private boolean shouldCollectSummaryString() {
+ return
hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_QUERY_HISTORY_SERVICE_ENABLED) &&
Review Comment:
can we eagerly initialize var in TezJobMonitor constructor instead of
evaluation from conf on every method call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
