Aggarwal-Raghav commented on code in PR #6242:
URL: https://github.com/apache/hive/pull/6242#discussion_r2642481758
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java:
##########
@@ -135,6 +135,9 @@ public ObjectInspector primitive(Type.PrimitiveType
primitiveType) {
return adjustToUTC ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
case TIME:
return IcebergTimeObjectInspector.get();
+ case TIMESTAMP_NANO:
+ boolean adjust = ((Types.TimestampNanoType)
primitiveType).shouldAdjustToUTC();
+ return adjust ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
Review Comment:
following classes doesn't exists since iceberg 1.8.0, can we get rid of
them? Maybe as part of separate JIRA?
```
org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspector
org.apache.iceberg.mr.hive.serde.objectinspector.IcebergTimestampObjectInspector
org.apache.iceberg.mr.hive.serde.objectinspector.IcebergTimestampWithZoneObjectInspector
```
https://github.com/apache/hive/blob/3d58586b45121f58cdcbf0ddbaa11ab08408d35b/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java#L54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
