ayushtkn commented on code in PR #6242:
URL: https://github.com/apache/hive/pull/6242#discussion_r2642847602
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java:
##########
@@ -135,6 +135,9 @@ public ObjectInspector primitive(Type.PrimitiveType
primitiveType) {
return adjustToUTC ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
case TIME:
return IcebergTimeObjectInspector.get();
+ case TIMESTAMP_NANO:
+ boolean adjust = ((Types.TimestampNanoType)
primitiveType).shouldAdjustToUTC();
+ return adjust ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
Review Comment:
AFAIK
Nanosecond precision is preserved because all conversions are done using:
* java.time.ZonedDateTime
* java.time.OffsetDateTime
* org.apache.hadoop.hive.common.type.TimestampTZ
All of these internally store time with nanosecond resolution
If you check the q file output, I have a case for all 4 types, and for the
nanosecond timezones, it would be more digits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
