ayushtkn commented on code in PR #6242:
URL: https://github.com/apache/hive/pull/6242#discussion_r2642842543
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java:
##########
@@ -135,6 +135,9 @@ public ObjectInspector primitive(Type.PrimitiveType
primitiveType) {
return adjustToUTC ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
case TIME:
return IcebergTimeObjectInspector.get();
+ case TIMESTAMP_NANO:
+ boolean adjust = ((Types.TimestampNanoType)
primitiveType).shouldAdjustToUTC();
+ return adjust ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
Review Comment:
I think they are kept for compat, there is bunch of checks in Hive code for
iceberg checking is Minimum version Hive-3 or so, need to think seprately if we
want to maintain such compat or can drop all those checks & hacks for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
