Aggarwal-Raghav commented on code in PR #6242:
URL: https://github.com/apache/hive/pull/6242#discussion_r2642576712
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java:
##########
@@ -135,6 +135,9 @@ public ObjectInspector primitive(Type.PrimitiveType
primitiveType) {
return adjustToUTC ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
case TIME:
return IcebergTimeObjectInspector.get();
+ case TIMESTAMP_NANO:
+ boolean adjust = ((Types.TimestampNanoType)
primitiveType).shouldAdjustToUTC();
+ return adjust ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
Review Comment:
```
case TIMESTAMP_NANO:
boolean adjust = ((Types.TimestampNanoType)
primitiveType).shouldAdjustToUTC();
return adjust ? TIMESTAMP_INSPECTOR_WITH_TZ : TIMESTAMP_INSPECTOR;
```
I don't see any "nanos" usage in
`IcebergTimestampWithZoneObjectInspectorHive3` i.e.
`TIMESTAMPTZ_INSPECTOR_CLASS` , should we create a new class extending
`AbstractPrimitiveJavaObjectInspector` for handling nano case? Also
`TIMESTAMP_INSPECTOR` will not return "nanosecond timestamp"
https://github.com/apache/hive/blob/eaa8189600c74efa35cc9975eea0f81df59e5088/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java#L41-L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
