Aggarwal-Raghav commented on code in PR #6242:
URL: https://github.com/apache/hive/pull/6242#discussion_r2643917159
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
Review Comment:
I'm not following completely, can you please help me understand. The iceberg
issue you mentioned is fixed as part of iceberg 1.10.0 (PR 13746 and 13747) and
hive is on iceberg 1.10.0. Will the following won't work?
```
case TIMESTAMP_NANO:
if (value instanceof Long) {
Types.TimestampNanoType timestampType = (Types.TimestampNanoType)
type;
return timestampType.shouldAdjustToUTC()
? DateTimeUtil.timestamptzFromNanos((Long) value)
: DateTimeUtil.timestampFromNanos((Long) value);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
