sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862231668
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -873,7 +874,8 @@ Result<std::vector<std::shared_ptr<Schema>>>
ParquetDatasetFactory::InspectSchem
size_t i = 0;
for (const auto& e : paths_with_row_group_ids_) {
- stripped[i++] = StripPrefixAndFilename(e.first,
options_.partition_base_dir);
+ stripped[i++] =
+ StripPrefixAndFilename(e.first,
options_.partition_base_dir).directory;
Review Comment:
The `Inspect()` methods now accept a `PartitionPathFormat` object as an
argument with the latest commit. I have modified the tests and
`SplitFilenameAndPrefix()` methods to return forms of PartitionPathFormat
object as required. The `Inspect()` methods then extracts the directory or
prefix accordingly whichever is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
