lidavidm commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862081385
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -873,7 +874,8 @@ Result<std::vector<std::shared_ptr<Schema>>>
ParquetDatasetFactory::InspectSchem
size_t i = 0;
for (const auto& e : paths_with_row_group_ids_) {
- stripped[i++] = StripPrefixAndFilename(e.first,
options_.partition_base_dir);
+ stripped[i++] =
+ StripPrefixAndFilename(e.first,
options_.partition_base_dir).directory;
Review Comment:
That probably makes the most sense, but we might want to split out that
refactoring separately, and also make sure that we can hit this path in a unit
test in the first place (I was trying this morning but couldn't) as I don't
want to expand the scope of this PR too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
