sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862080350
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -873,7 +874,8 @@ Result<std::vector<std::shared_ptr<Schema>>>
ParquetDatasetFactory::InspectSchem
size_t i = 0;
for (const auto& e : paths_with_row_group_ids_) {
- stripped[i++] = StripPrefixAndFilename(e.first,
options_.partition_base_dir);
+ stripped[i++] =
+ StripPrefixAndFilename(e.first,
options_.partition_base_dir).directory;
Review Comment:
I think we can do the same changes in the `Inspect()` method which currently
accepts a path. Instead of passing a vector of strings, we can then pass a
vector of `PartitionPathFormat` object, and then the `Inspect` methods of
individual partitioning modes will use either the directory or the filename
accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
