sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862046122
##########
python/pyarrow/_dataset.pyx:
##########
@@ -1313,9 +1313,12 @@ cdef class Partitioning(_Weakrefable):
cdef inline shared_ptr[CPartitioning] unwrap(self):
return self.wrapped
- def parse(self, path):
+ def parse(self, directory="", prefix=""):
Review Comment:
Previously, when the `parse()` method only accepted a path, we used to pass
the filename there, as FilenamePartitioning only needs the filename and not the
directory. But, now that it is expecting both a directory and filename prefix,
so I believe a directory will not be required for FilenamePartitioning, thus
using an empty string as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
