lidavidm commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862060024
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -847,7 +847,8 @@ ParquetDatasetFactory::CollectParquetFragments(const
Partitioning& partitioning)
auto row_groups = Iota(metadata_subset->num_row_groups());
auto partition_expression =
- partitioning.Parse(StripPrefixAndFilename(path,
options_.partition_base_dir))
+ partitioning
+ .Parse(StripPrefixAndFilename(path,
options_.partition_base_dir).directory)
Review Comment:
Making sure that a filename partitioning works properly in this path,
basically, since before it seems like it would have failed since the filename
was being omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
