lidavidm commented on code in PR #13364: URL: https://github.com/apache/arrow/pull/13364#discussion_r894928013
########## cpp/src/arrow/compute/kernels/codegen_internal.h: ########## @@ -397,14 +400,198 @@ struct BoxScalar<Decimal256Type> { static void Box(T val, Scalar* out) { checked_cast<ScalarType*>(out)->value = val; } }; -// A VisitArrayDataInline variant that calls its visitor function with logical +// ---------------------------------------------------------------------- +// Like VisitArrayDataInline, but for ArraySpans Review Comment: If we can migrate everything I would rather have only one code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org