wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066967
##########
cpp/src/arrow/compute/kernels/codegen_internal.h:
##########
@@ -397,14 +400,198 @@ struct BoxScalar<Decimal256Type> {
static void Box(T val, Scalar* out) { checked_cast<ScalarType*>(out)->value
= val; }
};
-// A VisitArrayDataInline variant that calls its visitor function with logical
+// ----------------------------------------------------------------------
+// Like VisitArrayDataInline, but for ArraySpans
Review Comment:
done (removed VisitArrayDataInline)! I added implicit construction of
ArraySpan which indeed feels more natural and makes the "unboxing" to raw
pointers happen in a single place, rather than having code generated that
duplicates the unboxing each time this template is instantiated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
