wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066814
##########
cpp/src/arrow/type.h:
##########
@@ -126,7 +126,8 @@ struct ARROW_EXPORT DataTypeLayout {
///
/// Simple datatypes may be entirely described by their Type::type id, but
/// complex datatypes are usually parametric.
-class ARROW_EXPORT DataType : public detail::Fingerprintable {
+class ARROW_EXPORT DataType : public std::enable_shared_from_this<DataType>,
Review Comment:
I renamed GetSharedPtr to Copy and leaving the implementation which we can
revisit later
##########
cpp/src/arrow/scalar.h:
##########
@@ -49,7 +49,8 @@ class Array;
/// Scalars are useful for passing single value inputs to compute functions,
/// or for representing individual array elements (with a non-trivial
/// wrapping cost, though).
-struct ARROW_EXPORT Scalar : public util::EqualityComparable<Scalar> {
+struct ARROW_EXPORT Scalar : public std::enable_shared_from_this<Scalar>,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
