wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r895066801
##########
cpp/src/arrow/util/bit_block_counter.h:
##########
@@ -490,26 +493,34 @@ static void VisitBitBlocksVoid(const
std::shared_ptr<Buffer>& bitmap_buf, int64_
}
template <typename VisitNotNull, typename VisitNull>
-static Status VisitTwoBitBlocks(const std::shared_ptr<Buffer>& left_bitmap_buf,
- int64_t left_offset,
- const std::shared_ptr<Buffer>&
right_bitmap_buf,
- int64_t right_offset, int64_t length,
- VisitNotNull&& visit_not_null, VisitNull&&
visit_null) {
- if (left_bitmap_buf == NULLPTR || right_bitmap_buf == NULLPTR) {
+static void VisitBitBlocksVoid(const std::shared_ptr<Buffer>& bitmap_buf,
int64_t offset,
Review Comment:
I am removing the other ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
