drin commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r920274126
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
}
+ Status MaybeInsert(const Scalar& value) {
Review Comment:
ah, yeah I think it can. It just seemed like it might be nice to have a
slightly simpler code path. but I can drop this and use GetOrInsert if we prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
