wesm commented on code in PR #13583:
URL: https://github.com/apache/arrow/pull/13583#discussion_r920552152
##########
r/tests/testthat/test-dplyr-summarize.R:
##########
@@ -218,6 +218,15 @@ test_that("Group by any/all", {
)
})
+test_that("n_distinct() with many batches", {
+ tf <- tempfile()
Review Comment:
Use spaces instead of tabs
##########
cpp/src/arrow/util/hashing.h:
##########
@@ -428,6 +428,22 @@ class ScalarMemoTable : public MemoTable {
value, [](int32_t i) {}, [](int32_t i) {}, out_memo_index);
}
+ Status MaybeInsert(const Scalar& value) {
Review Comment:
Or at least implement this new API with `GetOrInsert` — the `Status
GetOrInsert(const Scalar& value, int32_t* out_memo_index)` version should
generate the same code more or less as this (with the exception of the unused
index)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
