icexelloss commented on code in PR #33676:
URL: https://github.com/apache/arrow/pull/33676#discussion_r1073794299
##########
cpp/src/arrow/compute/exec/asof_join_node_test.cc:
##########
@@ -662,19 +662,19 @@ TRACED_TEST_P(AsofJoinBasicTest, TestBasic1, {
runner(basic_test);
})
-BasicTest GetBasicTest1Negative() {
Review Comment:
Let's name these tests "backward" or "forward" similar to how pandas call
them:
https://pandas.pydata.org/pandas-docs/version/0.25.0/reference/api/pandas.merge_asof.html#pandas-merge-asof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
