[GitHub] [arrow] rtpsw commented on a diff in pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

[via GitHub]

rtpsw commented on code in PR #33676:
URL: https://github.com/apache/arrow/pull/33676#discussion_r1083261065


##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -523,7 +523,8 @@ class ARROW_EXPORT AsofJoinNodeOptions : public 
ExecNodeOptions {
   ///
   /// \see `Keys` for details.
   std::vector<Keys> input_keys;
-  /// \brief Tolerance for inexact "on" key matching.  Must be non-negative.
+  /// \brief Tolerance for inexact "on" key matching. Positive (resp. 
negative) tolerance
+  /// is interpreted as a future (resp. past) as-of-join.

Review Comment:
   The match condition is actually (now) reversed. I committed a more detailed 
doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org