icexelloss commented on code in PR #34279:
URL: https://github.com/apache/arrow/pull/34279#discussion_r1113402829
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -3049,21 +3055,22 @@ TEST(SubstraitRoundTrip, JoinRel) {
[10, 1, 10, 11]
])"});
- NamedTableProvider table_provider =
- [left_table, right_table](const std::vector<std::string>& names) {
- std::shared_ptr<Table> output_table;
- for (const auto& name : names) {
- if (name == "left") {
- output_table = left_table;
- }
- if (name == "right") {
- output_table = right_table;
- }
- }
- std::shared_ptr<compute::ExecNodeOptions> options =
-
std::make_shared<compute::TableSourceNodeOptions>(std::move(output_table));
- return compute::Declaration("table_source", {}, options,
"mock_source");
- };
+ NamedTableProvider table_provider = [left_table, right_table](
Review Comment:
Only interface and format change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
