icexelloss commented on code in PR #34279:
URL: https://github.com/apache/arrow/pull/34279#discussion_r1113407751
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -2309,11 +2310,16 @@ TEST(SubstraitRoundTrip, FilterNamedTable) {
])"});
NamedTableProvider table_provider =
- [&input_table, &table_names](
- const std::vector<std::string>& names) ->
Result<compute::Declaration> {
+ [&input_table, &table_names, &dummy_schema](
+ const std::vector<std::string>& names,
+ const std::shared_ptr<Schema> schema) ->
Result<compute::Declaration> {
if (table_names != names) {
return Status::Invalid("Table name mismatch");
}
+ if (!dummy_schema->Equals(*schema)) {
Review Comment:
Added checks here to ensure schema is passed in correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
