westonpace commented on code in PR #34279:
URL: https://github.com/apache/arrow/pull/34279#discussion_r1113640124
##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -65,8 +65,8 @@ enum class ARROW_ENGINE_EXPORT ConversionStrictness {
BEST_EFFORT,
};
-using NamedTableProvider =
- std::function<Result<compute::Declaration>(const
std::vector<std::string>&)>;
+using NamedTableProvider = std::function<Result<compute::Declaration>(
+ const std::vector<std::string>&, const std::shared_ptr<Schema>)>;
Review Comment:
Please use `const Schema&`. `shared_ptr` should only be needed if the
caller is likely to extend ownership. In the rare case that is needed the
caller can just make their own copy.
If you do think it is likely that caller will need to extend ownership you
can use `const std::shared_ptr<Schema>&` (`const &` and not just `const`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
