thisisnic commented on code in PR #37727:
URL: https://github.com/apache/arrow/pull/37727#discussion_r1326522658
##########
r/tools/nixlibs.R:
##########
@@ -473,17 +473,20 @@ build_libarrow <- function(src_dir, dst_dir) {
env_vars <- env_vars_as_string(env_var_list)
cat("**** arrow", ifelse(quietly, "", paste("with", env_vars)), "\n")
- status <- suppressWarnings(system(
- paste(env_vars, "inst/build_arrow_static.sh"),
- ignore.stdout = quietly, ignore.stderr = quietly
+
+ status <- suppressWarnings(system2(
+ "bash",
Review Comment:
Yeah, I think my earlier approach (which is what @amoeba has done an
excellent job of fixing here!) which saves stuff to an R vector is not great,
as it leaves a lot of room for R weirdness. Perhaps @nealrichardson 's
suggestion from Zulip might be worth trying instead:
> Probably a better way would be to redirect the build output to a file, and
print the file name if the build fails so that you can inspect it (though an
installation of a source package would put that in a temp dir that would
probably be removed on exit)
> Could also print the last N lines of that output on failure (would have to
experiment to find a reasonable N), that might be enough guidance to debug
something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
