nealrichardson commented on code in PR #37727:
URL: https://github.com/apache/arrow/pull/37727#discussion_r1327157171
##########
r/tools/nixlibs.R:
##########
@@ -473,17 +473,20 @@ build_libarrow <- function(src_dir, dst_dir) {
env_vars <- env_vars_as_string(env_var_list)
cat("**** arrow", ifelse(quietly, "", paste("with", env_vars)), "\n")
- status <- suppressWarnings(system(
- paste(env_vars, "inst/build_arrow_static.sh"),
- ignore.stdout = quietly, ignore.stderr = quietly
+
+ status <- suppressWarnings(system2(
+ "bash",
Review Comment:
I was referring to the next line, looks like the mobile app attached the
comment to the wrong line. I'm not sure that directly calling "bash" is
necessary or a good idea--we didn't before, the script has a shebang at the
top, and bash might not be the shell that's available, a point that CRAN has
been pedantic about in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
