amoeba commented on code in PR #37727:
URL: https://github.com/apache/arrow/pull/37727#discussion_r1326578253
##########
r/tools/nixlibs.R:
##########
@@ -473,17 +473,20 @@ build_libarrow <- function(src_dir, dst_dir) {
env_vars <- env_vars_as_string(env_var_list)
cat("**** arrow", ifelse(quietly, "", paste("with", env_vars)), "\n")
- status <- suppressWarnings(system(
- paste(env_vars, "inst/build_arrow_static.sh"),
- ignore.stdout = quietly, ignore.stderr = quietly
+
+ status <- suppressWarnings(system2(
+ "bash",
Review Comment:
My experience with build failures matches what @assignUser refers to with
having to scroll up (sometimes quite far) to find the source of the failure.
One trick I use to bring the error down is to re-build without parallelism but
I'm not sure how best to implement that here.
So I'd be in favor of (1) writing to a file instead of capturing and (2)
cating the full file to hedge against the tempfile disappearing before someone
can grab it. I'll do that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
