amoeba commented on code in PR #37727:
URL: https://github.com/apache/arrow/pull/37727#discussion_r1327648554
##########
r/tools/nixlibs.R:
##########
@@ -473,17 +473,20 @@ build_libarrow <- function(src_dir, dst_dir) {
env_vars <- env_vars_as_string(env_var_list)
cat("**** arrow", ifelse(quietly, "", paste("with", env_vars)), "\n")
- status <- suppressWarnings(system(
- paste(env_vars, "inst/build_arrow_static.sh"),
- ignore.stdout = quietly, ignore.stderr = quietly
+
+ status <- suppressWarnings(system2(
+ "bash",
Review Comment:
Gotcha, that makes sense now. I thought the pre-existing reliance on bash in
nixlibs.R was odd, and we actually have this bit:
https://github.com/apache/arrow/blob/d9ee3a7961df44a1e30d3fe615ee3a20af569025/r/tools/nixlibs.R#L625-L627
and another spot where we make the `command` bash,
https://github.com/apache/arrow/blob/d9ee3a7961df44a1e30d3fe615ee3a20af569025/r/tools/nixlibs.R#L630
So this change adds some consistency. I'd be happy to changes things if/when
CRAN has any issues. Thanks for catching it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
