amoeba commented on code in PR #37727:
URL: https://github.com/apache/arrow/pull/37727#discussion_r1326615534
##########
r/tools/nixlibs.R:
##########
@@ -473,17 +473,20 @@ build_libarrow <- function(src_dir, dst_dir) {
env_vars <- env_vars_as_string(env_var_list)
cat("**** arrow", ifelse(quietly, "", paste("with", env_vars)), "\n")
- status <- suppressWarnings(system(
- paste(env_vars, "inst/build_arrow_static.sh"),
- ignore.stdout = quietly, ignore.stderr = quietly
+
+ status <- suppressWarnings(system2(
+ "bash",
Review Comment:
Alright, with
https://github.com/apache/arrow/pull/37727/commits/4246503793ca46040c4b941469a5876268f7c965,
we now redirect stdout/stderr to a tempfile and print that file out on a build
failure. The way I set it up, it looks like
> **** Error building Arrow C++.
> **** Printing contents of build log because the build failed while
ARROW_R_DEV was set to FALSE
> /* contents of build log */
> **** Complete build log is available at
/var/folders/vm/bbcxtl3s63l7gn9h1tvfh1mm0000gn/T//RtmpKBAT6R/file75d2a7f76ba.log
I printed the build log last in case we print so much information in the
prior step that the user's terminal truncates the first part of the output so
the user can still find the file (if it exists at this point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
