mbrobbel opened a new pull request, #1326: URL: https://github.com/apache/arrow-adbc/pull/1326
The main goal of this PR is to start making some changes that should help to get #1305 ready for review. I'll update that PR later to be compatible with the changes introduced here. A summary of the changes: - Add a [Cargo workspace](https://doc.rust-lang.org/cargo/reference/workspaces.html) for the Rust implementation of ADBC, this allow having separate crates for different components (like drivers). - Add a bindings crate `arrow-adbc-sys` to the workspace that auto generates bindings based on `adbc.h` using [bindgen](https://rust-lang.github.io/rust-bindgen/). There is a [symbolic link](https://github.com/mbrobbel/arrow-adbc/blob/rust-workspace/rust/bindings/adbc.h) to the `adbc.h` header in the bindings crate. I noticed that the go lib has a copy that is checked to be in sync with pre-commit, if that is preferred I can update. - Update some existing definitions to use the generated bindings. - Add [dependabot](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates) config to keep Rust dependencies up-to-date. - Remove usage of non-approved GitHub actions for Rust workflow. - Check in `Cargo.lock` file following [this blog post](https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html). - Remove an unused dev dependency. - Fixed some Clippy warnings. - Updated dependencies. - Remove `Adbc` prefix from item names. - Remove deprecated function from `std::error::Error` impl, added a `Result` type. - Added some missing ingest options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
