lidavidm commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406400586
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: To be clear: there's no requirement to have Rust mirror C 1:1. Staying close to the general structure to ease FFI makes sense, but you could absolutely choose to have pure-Rust definitions and translate to/from FFI definitions purely in the FFI code, instead of forcing all definitions to be identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
