mbrobbel commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406406905
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: Good question. `bindgen` [uses](https://rust-lang.github.io/rust-bindgen/requirements.html#clang) `clang` to parse and analyze headers. I think it's fine but others may disagree. I can revert this and keep copies of those definitions in Rust to prevent that dependency, and put the generated headers behind an `ffi` feature flag. Or an alternative approach: check in the generated bindings (and regenerate when `adbc.h` changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
