mbrobbel commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406376704
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: To be precise; the bindings here are generated items at build time based on `adbc.h`. The items are structs (e.g. `AdbcConnection`, `AdbcDatabase`), constants (e.g. `ADBC_VERSION_1_1_0`), functions (e.g. `AdbcDatabaseInit`) and type aliases (e.g. `AdbcStatusCode`). We could choose to put some of the defintions behind a `ffi` feature, but I think always using the constants from the header is sensible, considering `adbc.h` the single source of truth for these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
