lidavidm commented on code in PR #1326: URL: https://github.com/apache/arrow-adbc/pull/1326#discussion_r1406452234
########## rust/src/lib.rs: ########## @@ -64,25 +64,26 @@ pub mod objects; use std::collections::HashMap; +use arrow_adbc_sys as adbc; Review Comment: I would prefer pure-Rust or check-in bindings but if the typical Rust user does not actually care about this (I know Go users often prefer to avoid CGO entirely if not required as it makes cross-compilation and static binaries harder) then this is fine. But I'm not deeply involved in Rust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
