peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1933947559
> It's important to me that the behavior of the `Jump` remains consistent, whether we are traversing from the top-down or bottom-up. > > For the use case, you can consider a scenario where the user only interested in the leaf node transformations or investigations. This can be efficiently and easily managed by using `transform_up` with a rule that returns `Recursion::Jump`. > > The term "Jump" is intuitively understandable in this context, enabling users to grasp the intended functionality with ease. On the other hand, using "Prune" could lead to confusion, as it might imply the removal of nodes from the tree beyond the current point. In reality, we're just bypassing the child nodes, not eliminating any section of the tree. An example usage: https://www.geeksforgeeks.org/traversal-tree-ability-jump-nodes-height/ > > A fix for the design: You can think of jumping during bottom-up such as passing directly to the next leaf node. It may be more logical than jumping to the last node where the subtree separate. Please be more concreate and use the tree in https://synnada.notion.site/synnada/TreeNode-Design-Proposal-bceac27d18504a2085145550e267c4c1. Are you suggesting now that if `post_visit(A)` returns `Jump` then `post_visit(H)` should be called next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
