mustafasrepo commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1508528559
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -54,6 +55,24 @@ impl FirstValue {
input_data_type: DataType,
ordering_req: LexOrdering,
order_by_data_types: Vec<DataType>,
+ ) -> Self {
+ Self::with_ignore_null(
+ expr,
+ name,
+ input_data_type,
+ ordering_req,
+ order_by_data_types,
+ false,
+ )
+ }
+
+ pub fn with_ignore_null(
Review Comment:
Instead of this API, maybe we can use builder API as below
```rust
pub fn with_ignore_null(mut self, ignore_null: bool) -> Self{
self.ignore_null = ignore_null;
self
}
```
However, this purely stylistic. Feel free to proceed as you wish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
