viirya commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1508550980
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -213,6 +235,7 @@ struct FirstValueAccumulator {
ordering_req: LexOrdering,
// Stores whether incoming data already satisfies the ordering requirement.
requirement_satisfied: bool,
+ is_ignore_null: bool,
Review Comment:
It might be good to add a comment like above parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
