comphead commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1509243629
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -44,6 +44,7 @@ pub struct FirstValue {
expr: Arc<dyn PhysicalExpr>,
ordering_req: LexOrdering,
requirement_satisfied: bool,
+ is_ignore_null: bool,
Review Comment:
maybe we can use `ignore_nulls: bool`, it is consistent with SQL keywords
and also window functions that in parallel implementing IGNORE NULLS .
Would be also nice to have a comments in struct about this field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
