viirya commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1510342967
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -63,9 +64,15 @@ impl FirstValue {
expr,
ordering_req,
requirement_satisfied,
+ ignore_null: false,
}
}
+ pub fn ignore_null(mut self, ignore_null: bool) -> Self {
Review Comment:
For a builder style API, a common API name pattern should be (e.g., the
existing `with_requirement_satisfied`):
```suggestion
pub fn with_ignore_null(mut self, ignore_null: bool) -> Self {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
