comphead commented on PR #9411: URL: https://github.com/apache/arrow-datafusion/pull/9411#issuecomment-1973530866
> Hmm, I saw you implement it in physical expression `FirstValue`. But do you add `ignore null` parameter to logical one and pass it through logical to physical? I.e., does a query with first value + ignore null work now? Can you add an e2e test to sqllogictests? It should start with logical plan, from #9221 the null treatment is allowed for window functions now https://github.com/apache/arrow-datafusion/blob/main/datafusion/sql/src/expr/function.rs#L61 For agg I suppose we need to do the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
