huaxingao commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1510354435
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -44,6 +44,7 @@ pub struct FirstValue {
expr: Arc<dyn PhysicalExpr>,
ordering_req: LexOrdering,
requirement_satisfied: bool,
+ ignore_null: bool,
Review Comment:
I have change all of them to `ignore_nulls`. Thanks for catching this!
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -672,7 +672,7 @@ pub fn to_substrait_agg_measure(
),
) -> Result<Measure> {
match expr {
- Expr::AggregateFunction(expr::AggregateFunction { func_def, args,
distinct, filter, order_by }) => {
+ Expr::AggregateFunction(expr::AggregateFunction { func_def, args,
distinct, filter, order_by, .. }) => {
Review Comment:
Fixed. Thanks!
##########
datafusion/expr/src/expr.rs:
##########
@@ -544,6 +544,7 @@ pub struct AggregateFunction {
pub filter: Option<Box<Expr>>,
/// Optional ordering
pub order_by: Option<Vec<Expr>>,
+ pub null_treatment: Option<NullTreatment>,
Review Comment:
Added. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
