huaxingao commented on code in PR #9411:
URL: https://github.com/apache/arrow-datafusion/pull/9411#discussion_r1510354458
##########
datafusion/expr/src/expr.rs:
##########
@@ -1471,9 +1475,13 @@ impl fmt::Display for Expr {
ref args,
filter,
order_by,
+ null_treatment,
..
}) => {
fmt_function(f, func_def.name(), *distinct, args, true)?;
+ if let Some(nt) = null_treatment {
+ write!(f, "{}", nt)?;
Review Comment:
Changed. Thanks
##########
datafusion/expr/src/expr.rs:
##########
@@ -1823,6 +1832,9 @@ fn create_name(e: &Expr) -> Result<String> {
if let Some(order_by) = order_by {
info += &format!(" ORDER BY [{}]", expr_vec_fmt!(order_by));
};
+ if let Some(nt) = null_treatment {
+ info += &format!("{}", nt);
Review Comment:
Changed. Thanks
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -63,9 +64,15 @@ impl FirstValue {
expr,
ordering_req,
requirement_satisfied,
+ ignore_null: false,
}
}
+ pub fn ignore_null(mut self, ignore_null: bool) -> Self {
Review Comment:
Changed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
