wgtmac commented on PR #43957:
URL: https://github.com/apache/arrow/pull/43957#issuecomment-2332009931

   > > Following the same pattern, this change means that using 
`decimal(precision, scale)` instead of the specific 
`decimal32`/`decimal64`/`decimal128`/`decimal256` functions results in the 
following functionality
   > 
   > I'm afraid this may massively break user code. I would suggest another 
approach:
   > 
   > * deprecate the `decimal()` factory while keeping its current behavior of 
always returning at least `decimal128`
   > * introduce a new `smallest_decimal()` factory that is documented to 
return the smallest possible type, and explicitly makes no guarantees about the 
stability of the return type
   
   I just have the same concern. +1 on the proposed workaround.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to