zeroshade commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1747615412
##########
cpp/src/arrow/type.cc:
##########
@@ -3301,8 +3356,18 @@ std::shared_ptr<Field> field(std::string name,
std::shared_ptr<DataType> type,
}
std::shared_ptr<DataType> decimal(int32_t precision, int32_t scale) {
- return precision <= Decimal128Type::kMaxPrecision ? decimal128(precision,
scale)
- : decimal256(precision,
scale);
+ return precision <= Decimal32Type::kMaxPrecision ? decimal32(precision,
scale)
Review Comment:
the updated version does exactly that, added a deprecation notice and
created a new function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
