felipecrv commented on code in PR #43957: URL: https://github.com/apache/arrow/pull/43957#discussion_r1752036013
########## cpp/src/arrow/compute/kernels/codegen_internal.h: ########## @@ -224,7 +258,9 @@ using enable_if_not_floating_value = enable_if_t<!std::is_floating_point<T>::val template <typename T, typename R = T> using enable_if_decimal_value = - enable_if_t<std::is_same<Decimal128, T>::value || std::is_same<Decimal256, T>::value, + enable_if_t<std::is_same<Decimal32, T>::value || std::is_same<Decimal64, T>::value || + std::is_same<Decimal128, T>::value || + std::is_same<Decimal256, T>::value, Review Comment: By safe I mean: all the things someone assumed when they wrote an `enable_if_decimal` still hold. And you're saying you checked all of them with `GetSumType` being the only one where assumptions didn't hold well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
